Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qpdf: 9.1.1 -> 10.0.1 #97752

Merged
merged 1 commit into from Sep 13, 2020
Merged

qpdf: 9.1.1 -> 10.0.1 #97752

merged 1 commit into from Sep 13, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Sep 11, 2020 •
edited

Use fetchFromGitHub. Remove 1 patchShebangs hook now unneeded.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
qpdf: 9.1.1 -> 10.0.1
5262662 
Use fetchFromGitHub. Remove 1 patchShebangs hook now unneeded.
@doronbehar doronbehar mentioned this pull request Sep 11, 2020
Closed
@doronbehar
Copy link
Contributor Author

@GrahamcOfBorg build cups-filters img2pdf ocrmypdf pdfarranger python37Packages.img2pdf python37Packages.pikepdf python38Packages.pikepdf splix system-config-printer

@ofborg ofborg bot requested a review from abbradar September 11, 2020 10:29
@doronbehar
Copy link
Contributor Author

The darwin build once again hangs for ever, and all reverse deps of qpdf build fine both on aarch64 and x86_64. I'm merging.

@doronbehar doronbehar merged commit bdbe60a into NixOS:master Sep 13, 2020
@doronbehar doronbehar deleted the pkg/qpdf branch September 13, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@doronbehar