pyvips: init at 2.1.12 #98866

ccellado · 2020-09-26T14:46:06Z

Motivation for this change

Add python bindings for libvips in API mode to nixpkgs rep.

Things done

jonringer · 2020-09-26T19:01:36Z

pkgs/development/python-modules/pyvips/default.nix

+{ buildPythonPackage, fetchPypi, python, pytestrunner, gcc, glib, cffi
+, python3Packages, pkgconfig, stdenv, vips, lib}:


Using pythonXPackages isn't allowed from python-modules as this will mix interpreter versions for a given package. For example, if you were to do python37Packages.<mypkg>, but the expression pulled from python3[8]Packages. Python will be mis-importing several libraries, and this will likely cause issues at runtime.

Please refer to Python dependency handling on the best practices for handling dependencies within python-modules. Namely, you should be importing each python package individually, and not refer to another python package set (E.g. python3Packages).

If you're new to nixpkgs, you're free to view some of my videos on nixpkgs and python:

Python packaging using nixpkgs

Adding a package to nixpkgs unstable

pkgs/development/python-modules/pyvips/default.nix

jonringer · 2020-09-26T19:04:37Z

pkgs/development/python-modules/pyvips/default.nix

+{ buildPythonPackage, fetchPypi, python, pytestrunner, gcc, glib, cffi
+, python3Packages, pkgconfig, stdenv, vips, lib}:


Remove unused and invalid packages

Suggested change

{ buildPythonPackage, fetchPypi, python, pytestrunner, gcc, glib, cffi

, python3Packages, pkgconfig, stdenv, vips, lib}:

{ buildPythonPackage, fetchPypi, pytestrunner, glib, cffi

, pkg-config, vips, lib}:

pkgs/top-level/python-packages.nix

pkgs/development/python-modules/pyvips/default.nix

ccellado · 2020-09-26T20:51:55Z

@jonringer i've tried all of your suggestions and the package doesn't build anymore.

My original recipe should see at compile time the pkgconfig files, now it says
"ERROR: Could not find a version that satisfies the requirement pkgconfig (from versions: none)
ERROR: No matching distribution found for pkgconfig"

jonringer

here's how I would package this:

python-packages.nix

  pyvips = callPackage ../development/python-modules/pyvips {
    inherit (pkgs) glib pkg-config vips;
  };

pyvips/default.nix:

{ lib, buildPythonPackage, fetchPypi
, pytestrunner
, pytestCheckHook
, glib
, cffi
, pkgconfig
, pkg-config
, vips
}:

buildPythonPackage rec {
  pname = "pyvips";
  version = "2.1.12";

  src = fetchPypi {
    inherit pname version;
    sha256 = "0pg0dxhxgi2m7bb5bi5wpx9hgnbi8ws1bz6w2dldbhi52pizghl4";
  };

  nativeBuildInputs = [
    pkg-config # for pkg-config hook
    pkgconfig  # python package
    pytestrunner
  ];

  buildInputs = [
    glib
    vips
  ];

  propagatedBuildInputs = [ cffi ];

  # no tests in pypi tarball
  doCheck = false;
  checkInputs = [ pytestCheckHook ];

  pythonImportsCheck = [ "pyvips" ];

  meta = with lib; {
    description = "A python wrapper for libvips";
    homepage = "https://github.com/libvips/pyvips";
    license = licenses.mit;
    maintainers = with maintainers; [ ccellado ];
  };
}

jonringer · 2020-09-27T01:40:24Z

one of my suggestions i forgot to include a closing ''; so it was failing to eval

ccellado · 2020-09-27T01:59:29Z

Now it works and I hope its good!

I'm new to the whole nix packaging thing - doing this one took me several months to complete in API mode.
Sometimes the documentation is too arcane or I am not so through to get the specifics.

Thank you for the patience.

ccellado · 2020-09-27T02:01:53Z

At last: for some reason this bit won't work

checkInputs = [ pytestCheckHook ];

It says : "error: undefined variable 'pytestCheckHook'"

jonringer · 2020-09-27T02:02:52Z

At last: for some reason this bit won't work

checkInputs = [ pytestCheckHook ];

It says : "error: undefined variable 'pytestCheckHook'"

looks like I forgot to re-add it when i was reformatting the inputs, I adjusted the original comment

ccellado · 2020-09-27T02:04:16Z

Oh, so you have to add it explicitly.

The manual says it's in the buildPythonPackage module... well that's that.

Thanks again, I'll summarize the commits.

jonringer · 2020-09-27T02:04:21Z

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.

This can be done without git rebase -i by doing:

git reset HEAD~7                   # move fix-up commits into unstaged
git add -- pkgs/                    # move changes into staged
git commit --amend --no-edit        # add changes to previous commit
git push ... ... --force            # modify current PR branch

However, git rebase -i is a more powerful alternative, I created a small video demonstrating it's use here. A more indepth text tutorial can be found here

pkgs/development/python-modules/pyvips/default.nix

pyvips: init at 2.1.12 pyvips: init at 2.1.12 Update pkgs/development/python-modules/pyvips/default.nix Co-authored-by: Jon <jonringer@users.noreply.github.com> Update pkgs/development/python-modules/pyvips/default.nix Co-authored-by: Jon <jonringer@users.noreply.github.com> Update pkgs/development/python-modules/pyvips/default.nix Co-authored-by: Jon <jonringer@users.noreply.github.com> Update pkgs/development/python-modules/pyvips/default.nix Co-authored-by: Jon <jonringer@users.noreply.github.com> Update pkgs/development/python-modules/pyvips/default.nix Co-authored-by: Jon <jonringer@users.noreply.github.com> Update pkgs/top-level/python-packages.nix Co-authored-by: Jon <jonringer@users.noreply.github.com> Update pkgs/development/python-modules/pyvips/default.nix Co-authored-by: Jon <jonringer@users.noreply.github.com> pyvips: init at 2.1.12 Update pkgs/development/python-modules/pyvips/default.nix Co-authored-by: Jon <jonringer@users.noreply.github.com>

jonringer

LGTM

Result of nixpkgs-review pr 98866 1

3 packages built:

python27Packages.pyvips
python37Packages.pyvips
python38Packages.pyvips

ccellado requested review from FRidh and jonringer as code owners September 26, 2020 14:46

ofborg bot added 6.topic: python 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 26, 2020

jonringer reviewed Sep 26, 2020

View reviewed changes

ccellado requested a review from jonringer September 26, 2020 21:01

jonringer reviewed Sep 27, 2020

View reviewed changes

pkgs/development/python-modules/pyvips/default.nix Show resolved Hide resolved

marsam approved these changes Sep 27, 2020

View reviewed changes

jonringer approved these changes Sep 28, 2020

View reviewed changes

jonringer merged commit 2f4f052 into NixOS:master Sep 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pyvips: init at 2.1.12 #98866

pyvips: init at 2.1.12 #98866

ccellado commented Sep 26, 2020

jonringer Sep 26, 2020

jonringer Sep 26, 2020

ccellado commented Sep 26, 2020

jonringer left a comment •

edited

jonringer commented Sep 27, 2020

ccellado commented Sep 27, 2020

ccellado commented Sep 27, 2020

jonringer commented Sep 27, 2020

ccellado commented Sep 27, 2020

jonringer commented Sep 27, 2020 •

edited

jonringer left a comment

		{ buildPythonPackage, fetchPypi, python, pytestrunner, gcc, glib, cffi
		, python3Packages, pkgconfig, stdenv, vips, lib}:

pyvips: init at 2.1.12 #98866

pyvips: init at 2.1.12 #98866

Conversation

ccellado commented Sep 26, 2020

Motivation for this change

Things done

jonringer Sep 26, 2020

Choose a reason for hiding this comment

jonringer Sep 26, 2020

Choose a reason for hiding this comment

ccellado commented Sep 26, 2020

jonringer left a comment • edited

Choose a reason for hiding this comment

jonringer commented Sep 27, 2020

ccellado commented Sep 27, 2020

ccellado commented Sep 27, 2020

jonringer commented Sep 27, 2020

ccellado commented Sep 27, 2020

jonringer commented Sep 27, 2020 • edited

jonringer left a comment

Choose a reason for hiding this comment

jonringer left a comment •

edited

jonringer commented Sep 27, 2020 •

edited