boost: fix segfaults on ppc64 #98822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-burns
force-pushed
the
ppc64le-boost-segfault
branch
from
112443f
to
562498c
Compare
|
I've updated this to what I believe is a more correct approach, since this is not actually an issue with nix. Since the bugfix in question applies cleanly to a large range of boost versions, I'm backporting the patch so that any other packages (not just nix) using older boost versions will also get the required fix. Again, this only applies to ppc64, so should not cause any rebuilds. |
|
Pinging maintainer @peti, looks like ofborg didn't request review |
r-burns
force-pushed
the
ppc64le-boost-segfault
branch
2 times, most recently
from
e3a814f
to
a544fa2
Compare
|
Updated to use fetchpatch to cut down on patch bloat |
r-burns
force-pushed
the
ppc64le-boost-segfault
branch
from
a544fa2
to
3c093bc
Compare
Fixes NixOS/nix#2517 See also: boostorg/context#72 boostorg/fiber#193 These issues have been resolved by: boostorg/context#106 boostorg/context@d4608a4 which is merged into boost as of v1.71.0. This feature was introduced (with the bug) in boost v1.61 and was fixed in v1.71. So we apply the patch to all versions in that range.
r-burns
force-pushed
the
ppc64le-boost-segfault
branch
from
3c093bc
to
969afc4
Compare
|
#100807 (comment) |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NixOS/nix#2517
See also:
boostorg/context#72
boostorg/fiber#193
These issues have been resolved by:
boostorg/context#106
boostorg/context@d4608a4
which is merged into boost as of v1.71.0.
This feature was introduced (with the bug) in
boost v1.61 and was fixed in v1.71. So we apply
the patch to all versions in that range.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after) (should have NO IMPACT on non-ppc64 platforms)