Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sacc: 1.01 -> 1.02 #98850

Closed
wants to merge 1 commit into from
Closed

sacc: 1.01 -> 1.02 #98850

wants to merge 1 commit into from

Conversation

rapenne-s
Copy link
Member

Motivation for this change

Software update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

sternenseemann
sternenseemann requested changes Sep 26, 2020
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the sha256 hash otherwise the old source will be fetched from NixOS' binary caches.

@sternenseemann sternenseemann mentioned this pull request Sep 26, 2020
Merged
10 tasks
@rapenne-s
Copy link
Member Author

You need to update the sha256 hash otherwise the old source will be fetched from NixOS' binary caches.

I note it for next time. I thought the sha256 was a constant value of the git repository.
I close this duplicate PR to only keep #98852

@rapenne-s rapenne-s closed this Sep 26, 2020
@sternenseemann
Copy link
Member

Relevant chapters from the docs which explain how sources are fetched and fixed-output derivations in general:

@rapenne-s rapenne-s deleted the update/sacc branch October 6, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rapenne-s @sternenseemann