New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sacc: 1.01 → 1.02 #98852
sacc: 1.01 → 1.02 #98852
Conversation
@GrahamcOfBorg build sacc |
Duplicate (with the difference of the switch to gopher) of #98850 |
I can compile it and it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, build and works on amd64
Result of 1 package built:
|
Thanks! I'm still not sure how I feel about the gopher fetchurl. Curl is unlikely to drop the gopher support anytime soon, however we currently do not fetch anything via this protocol on nixpkgs. I'm gonna wait for a second opinion before merging that. |
looks like it's also available at ftp://bitreich.org/releases/sacc/sacc-1.02.tgz |
03fca20
to
00251c0
Compare
Good catch, FTP is definitely a better option for downloading binary files than Gopher. Force pushed to use ftp. |
Nit: it's best to stick to https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes |
Motivation for this change
Update
sacc
to 1.02.cc @rapenne-s
Also switched download from
fetchgit
tofetchurl
using the gopher protocol. Are there any objections to this? Fetching the tarball via gopher is faster than checking out the git repository so I think it's desireable, the question is if we want to support this protocol indefinitely (I guess if we continue using curl we will).Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)