Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sacc: 1.01 → 1.02 #98852

Merged
merged 1 commit into from Nov 14, 2020
Merged

sacc: 1.01 → 1.02 #98852

merged 1 commit into from Nov 14, 2020

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Sep 26, 2020

Motivation for this change

Update sacc to 1.02.

cc @rapenne-s

Also switched download from fetchgit to fetchurl using the gopher protocol. Are there any objections to this? Fetching the tarball via gopher is faster than checking out the git repository so I think it's desireable, the question is if we want to support this protocol indefinitely (I guess if we continue using curl we will).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build sacc

@sternenseemann
Copy link
Member Author

Duplicate (with the difference of the switch to gopher) of #98850

@rapenne-s
Copy link
Member

I can compile it and it works.
Tested on NixOS amd64.

Copy link
Member

@rapenne-s rapenne-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, build and works on amd64

@picnoir
Copy link
Member

picnoir commented Nov 14, 2020

Result of nixpkgs-review pr 98852 1

1 package built:
  • sacc

@picnoir
Copy link
Member

picnoir commented Nov 14, 2020

Thanks!

I'm still not sure how I feel about the gopher fetchurl.

Curl is unlikely to drop the gopher support anytime soon, however we currently do not fetch anything via this protocol on nixpkgs.

I'm gonna wait for a second opinion before merging that.

@JJJollyjim
Copy link
Member

looks like it's also available at ftp://bitreich.org/releases/sacc/sacc-1.02.tgz

@sternenseemann
Copy link
Member Author

Good catch, FTP is definitely a better option for downloading binary files than Gopher. Force pushed to use ftp.

@picnoir picnoir merged commit 051345a into NixOS:master Nov 14, 2020
@picnoir
Copy link
Member

picnoir commented Nov 14, 2020

Nit: it's best to stick to -> in the commit message instead of using the symbol.

https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants