Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] shotcut: 20.07.11 -> 20.09.13, mlt: 6.20.0 -> 6.22.1 #98835

Merged
merged 1 commit into from Sep 27, 2020
Merged

[20.09] shotcut: 20.07.11 -> 20.09.13, mlt: 6.20.0 -> 6.22.1 #98835

merged 1 commit into from Sep 27, 2020

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Sep 26, 2020

Motivation for this change

backport #98786
(cherry picked from commit c835358)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [Xgg] Fits CONTRIBUTING.md.

@woffs
shotcut: 20.07.11 -> 20.09.13, mlt: 6.20.0 -> 6.22.1
57ef051 
and add updateScript

(cherry picked from commit c835358)
jonringer
jonringer approved these changes Sep 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/98835
1 package failed to build:
synfigstudio

6 packages built:
kdenlive libsForQt5.mlt libsForQt512.mlt libsForQt514.mlt mlt shotcut

@jonringer jonringer merged commit 2a7af8c into NixOS:release-20.09 Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@woffs @jonringer