Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace system() usage in SerializeWaveforms #198

Merged
merged 6 commits into from
Sep 27, 2020

Conversation

nshcat
Copy link
Collaborator

@nshcat nshcat commented Sep 26, 2020

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@nshcat nshcat marked this pull request as ready for review September 26, 2020 13:28
@nshcat nshcat changed the title [WIP] Replace system() usage in SerializeWaveforms Replace system() usage in SerializeWaveforms Sep 26, 2020
@azonenberg
Copy link
Collaborator

Can you refactor this into a separate function? Seems like something we might use elsewhere.

@nshcat
Copy link
Collaborator Author

nshcat commented Sep 27, 2020

will do

@azonenberg azonenberg merged commit 973cdeb into ngscopeclient:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OscilloscopeWindow::SerializeWaveforms relies on system() to delete existing waveforms
2 participants