Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux-next: new function to ease testing the newest kernels #98865

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

linux-next: new function to ease testing the newest kernels #98865

wants to merge 2 commits into from

Conversation

ikervagyok
Copy link
Contributor

Motivation for this change

Getting some tests done with the newest upstream patches without a lot of fiddling around.

Things done

Added a new function linux_next and a corresponding linuxPackages_next. These take a as an argument a set containing a date, a hash and maybe a version string (if linux_testing and the upstream RC version differ).

usage:

  boot.kernelPackages = pkgs.linuxPackages_next {
#   date = "20200924";
#   sha256 = "0r0vpa7k7pw6kq5200p9bf0xnmlya14lirdlbf6zmb9l04lcxxd3";
    date = "20200925";
    sha256 = "08kna2qn32ds8fs45gh74i0n9l8nx7ng3gj8rk58v4sip69snzgh";
#  version = "5.9.0-rc6-next";
  };
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm ryantm marked this pull request as draft October 23, 2020 02:57
@ikervagyok
Copy link
Contributor Author

Integrated lib.fakeSha256 and reworked the version part. It is now constructed by using the branch (e.g. 5.10) and the release candidate name (e.g. rc1).

Mandatory:

  • date
  • sha256

Optional:

  • extraMeta.branch
  • extraMeta.rc

@ikervagyok ikervagyok marked this pull request as ready for review October 28, 2020 23:15
@ryantm ryantm marked this pull request as draft October 31, 2020 14:01
@lheckemann
Copy link
Member

Sorry this has been left untouched for so long! I like the idea 👍

@ryantm why did you mark this as a draft?

@ryantm
Copy link
Member

ryantm commented Jan 17, 2021

@ryantm why did you mark this as a draft?

At some point I manually marked everything that has WIP in its title as draft. I didn't realize I was fighting with the author to un draft it. Sorry @ikervagyok.

@ryantm ryantm marked this pull request as ready for review January 17, 2021 14:34
@ryantm ryantm changed the title [WIP] linux-next: new function to ease testing the newest kernels linux-next: new function to ease testing the newest kernels Jan 17, 2021
@ikervagyok
Copy link
Contributor Author

@ryantm No hard feelings - It is a (working) draft ;)
@lheckemann Thanks for reviewing - I'll take a closer look in the next few days. Feel free to ping me, if I don't update until next week.

If there are any other improvements, I'm keen to hear them! I am not very familiar with upstream (testing) kernel versioning.

@lheckemann
Copy link
Member

@NeQuissimus might have some thoughts on this?

@NeQuissimus
Copy link
Member

LGTM

@ikervagyok
Copy link
Contributor Author

@Mic92 Description/Usage added.

@stale
Copy link

stale bot commented Jul 31, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 31, 2021
@xaverdh
Copy link
Contributor

xaverdh commented Oct 11, 2021

I would be very much interested in getting this merged!
@ikervagyok are you still working on this / can you rebase (it should now go into linux-kernels.nix instead of all-packages though)?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 11, 2021
@xaverdh xaverdh mentioned this pull request Oct 11, 2021
Closed
11 tasks
@xaverdh
Copy link
Contributor

xaverdh commented Oct 11, 2021

I can also rebase and take over the pr, if thats desired.

SuperSandro2000
SuperSandro2000 reviewed Oct 11, 2021
View reviewed changes
pkgs/os-specific/linux/kernel/linux-next.nix
@@ -0,0 +1,17 @@
{ stdenv, buildPackages, fetchurl, perl, buildLinux, modDirVersionArg ? null, lib, date, version, sha256, ... } @ args:

with stdenv.lib;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with stdenv.lib;
with lib;

that will not work anymore.

@ikervagyok
Copy link
Contributor Author

@xaverdh I'll take a look, but in general I'm a bit preoccupied nowadays. If you don't see enough progress, you are of course free to take over this pr ;)

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2022
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 7, 2023
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@wegank wegank marked this pull request as draft March 20, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@lheckemann lheckemann lheckemann left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@worldofpeace worldofpeace worldofpeace left review comments

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 0 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@ikervagyok @lheckemann @ryantm @NeQuissimus @xaverdh @Mic92 @SuperSandro2000 @worldofpeace @wegank