New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freecad: 0.18.4 -> unstable-2020-09-25 #98845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things are sometimes broken in the nightlies, I wonder if it would make sense to offer both, e.g. as freecad
and freecad-stable
packages?
8d196cf
to
96dfa21
Compare
Ok, I've added back a |
Fair warning, you're likely you be asked to squash these commits. The general rule is one commit per PR. We may also want to have a conversation about directly tracking their master. My concern is two-fold:
I suggest instead of tracking master directly, specify a hash and version it with the date. For example, the current would have a rev of 7616153b3c31ace006169cdc2fdafab484498858, and a version of "unstable-2020-09-25". Does that make sense? |
I'm not sure where you got that from. Usually we have one commit per changed package (with a commit message like
I think there is a slight misunderstanding here. This PR updates FreeCAD to the latest master version as of now. This version will not change until we update it the next time, in a separate PR. It will not suddenly break if new commits are pushed to the FreeCAD repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test but LGTM.
Thank you for the correction. I don't know how I misread that. Maybe I shouldn't be looking at PRs before midday? :-)
Perfect! |
I think it should have been |
At first I only wanted to upgrade If you think we should change the names to |
Given upstream does not support their stable version, I think it is fine with the current naming. I would even say we should drop |
ah, I was unaware of this |
Motivation for this change
We should be packaging the git version of FreeCAD instead of the latest "official" release. AFAICT almost everybody else is using the nightlies anyhow. Upstream doesn't even accept bug reports for 0.18.4.
As a side effect, we can finally upgrade opencascade-occt and get rid of one more qtwebkit dependency.
Fixes #98821
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)