Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave: enable Darwin build #98853

Closed
wants to merge 2 commits into from
Closed

Brave: enable Darwin build #98853

wants to merge 2 commits into from

Conversation

pniedzwiedzinski
Copy link
Contributor

@pniedzwiedzinski pniedzwiedzinski commented Sep 26, 2020 •
edited

Motivation for this change

I used Brave a lot on my linux machine, but as I switched to Mac I could not get it from Nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Sep 26, 2020
@ofborg ofborg bot requested review from rht and uskudnik September 26, 2020 13:04
@AndersonTorres AndersonTorres changed the title Add brave for darwin Brave: enable Darwin build Sep 29, 2020
@SuperSandro2000
Copy link
Member

Please fix the merge conflict and squash the commits together.

@siraben
Copy link
Member

siraben commented Jan 12, 2021

@pniedzwiedzinski poke, it'd be nice to have more graphical applications from Nixpkgs build on macOS.

@stale
Copy link

stale bot commented Jul 11, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 11, 2021
@stellarhoof
Copy link

Not stale

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 31, 2022
@SuperSandro2000
Copy link
Member

Not stale

It is stale because the merge conflict did not get resolve in over 3 months now.

@SuperSandro2000 SuperSandro2000 added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Feb 1, 2022
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 12, 2023
Janik-Haag
Janik-Haag reviewed Jun 19, 2023
View reviewed changes
Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pniedzwiedzinski are you still interested in getting this merged? I will close this in a few weeks if you aren't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janik-Haag Janik-Haag Janik-Haag left review comments

@rht rht Awaiting requested review from rht

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pniedzwiedzinski @SuperSandro2000 @siraben @stellarhoof @Janik-Haag @prusnak