Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libobjc2: unmark aarch64 as bad platform #98855

Merged
merged 1 commit into from Sep 27, 2020
Merged

libobjc2: unmark aarch64 as bad platform #98855

merged 1 commit into from Sep 27, 2020

Conversation

malte-v
Copy link
Contributor

@malte-v malte-v commented Sep 26, 2020 •
edited

Motivation for this change

libobjc2 compiles and runs (through SOGo) on my Raspberry Pi 4. Apparently the issue was fixed 5 years ago: gnustep/libobjc2@b952a21#diff-e49aa4e60f8ccec1be46afc5e6ffcee5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
Copy link
Contributor

@ofborg build gnustep.libobjc

danieldk
danieldk approved these changes Sep 27, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we can currently not rely on ofborg for AArch64 builds. Confirmed to work locally:

❯ nix-build default.nix --argstr system aarch64-linux -A gnustep.base          
[...]
/nix/store/8i7xf9r4dsi2494kjszvll526cayylli-gnustep-base-1.27.0

@danieldk danieldk merged commit dc6e00e into NixOS:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@malte-v @danieldk @Janik-Haag