Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitAndTools.git-remote-codecommit: init at 1.15.1 #98847

Merged
merged 1 commit into from Sep 29, 2020

Conversation

zaninime
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zaninime zaninime changed the title python3Packages.git-remote-codecommit: init at 1.15.1 gitAndTools.git-remote-codecommit: init at 1.15.1 Sep 29, 2020
@zaninime
Copy link
Contributor Author

@jonringer feel free to have a look again whenever you can.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98847 1

1 package built:
  • gitAndTools.git-remote-codecommit

@jonringer jonringer merged commit 6efc71f into NixOS:master Sep 29, 2020
@zaninime zaninime deleted the git-remote-codecommit branch July 30, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants