Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build standalone libvlc #98846

Merged
merged 12 commits into from Sep 26, 2020
Merged

Build standalone libvlc #98846

merged 12 commits into from Sep 26, 2020

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Sep 26, 2020

Motivation for this change

Use standalone libvlc instead of full VLC to reduce dependence on Qt and unnecessary rebuilds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ttuegel ttuegel merged commit 6882716 into NixOS:master Sep 26, 2020
ttuegel added a commit to ttuegel/nixpkgs that referenced this pull request Sep 26, 2020
Build standalone libvlc

(cherry picked from commit 6882716)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant