nixos/spice-webdavd: init #96325
Closed
nixos/spice-webdavd: init #96325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
kevincox
force-pushed
the
kevincox-phodav-udev
branch
8 times, most recently
from
635fd06
to
f8cd6ae
Compare
spice-webdavd installed in the guest allows file sharing with the host.
kevincox
force-pushed
the
kevincox-phodav-udev
branch
from
f8cd6ae
to
d8a30c1
Compare
|
/marvin opt-in |
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
1 similar comment
This comment has been minimized.
This comment has been minimized.
marvin-mk2
bot
requested review from
timokau
and removed request for
worldofpeace
Comment on lines
+24
to
+30
| outputs = [ "out" "dev" "lib" "udev" ]; | ||
|
|
||
| # We need to do this pre-configure otherwise the data/ folder disappears. | ||
| preConfigurePhases = ["udevInstallPhase"]; | ||
| udevInstallPhase = '' | ||
| install -vDt $udev/lib/udev/rules.d/ data/*-spice-webdavd.rules | ||
| ''; |
There was a problem hiding this comment.
I don't think we need an extra output for this tiny file. Just put it into $out.
|
It's been so long that I don't remember how I was testing this or whatever so I will just close it. It was working so anyone is welcome to pick it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Enable file sharing between a guest NixOS system and a host.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)