Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viw: init at 20171029 #96285

Merged
merged 1 commit into from Aug 26, 2020
Merged

viw: init at 20171029 #96285

merged 1 commit into from Aug 26, 2020

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Aug 25, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk suggested changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some requested changes.

I also wonder if it makes sense to add this to nixpkgs. It does not seem to be maintained anymore (the last commit is ~3 years ago). Also I wonder if it has any users. Perhaps this fits the NUR better?

pkgs/applications/editors/viw/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/viw/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/viw/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/viw/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/viw/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/viw/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/viw/default.nix Outdated Show resolved Hide resolved
@AndersonTorres
Copy link
Member Author

It is not updated because it is very stable and simple I think.

About the NUR: well, I need to study it! This being the case, maybe I will just reformat the expression locally and drop this PR.

@danieldk
Copy link
Contributor

It is not updated because it is very stable and simple I think.

About the NUR: well, I need to study it! This being the case, maybe I will just reformat the expression locally and drop this PR.

I didn't want to discourage submitting anything to nixpkgs. I was just not certain ;).

@AndersonTorres
Copy link
Member Author

@danieldk ping!

danieldk
danieldk approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cleaned up installPhase a little. LGTM.

Result of nixpkgs-review pr 96285 1

1 package built:
- viw

@danieldk danieldk merged commit 8a54067 into NixOS:master Aug 26, 2020
@AndersonTorres AndersonTorres deleted the upload-viw branch November 30, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndersonTorres @danieldk