Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open-policy-agent: 0.22.0 -> 0.23.2 #96291

Merged
merged 1 commit into from Aug 25, 2020
Merged

open-policy-agent: 0.22.0 -> 0.23.2 #96291

merged 1 commit into from Aug 25, 2020

Conversation

lucperkins
Copy link
Contributor

@lucperkins lucperkins commented Aug 25, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from nlewo August 25, 2020 16:02
@nlewo
Copy link
Member

nlewo commented Aug 25, 2020

Did you regenerate the deps.nix file?

@lucperkins
Copy link
Contributor Author

lucperkins commented Aug 25, 2020 •
edited

@nlewo I did, yes. That file appears to be unchanged between the two releases. Another option going forward would be to use buildGoModule instead, which would enable eliminating the deps.nix step.

@nlewo
Copy link
Member

nlewo commented Aug 25, 2020

yep, that would be an option, but it's fine for the current PR ;)

@nlewo nlewo merged commit 22293c2 into NixOS:master Aug 25, 2020
@nlewo
Copy link
Member

nlewo commented Aug 25, 2020

Thank you!

@lucperkins lucperkins deleted the open-policy-agent-0.23.2 branch August 25, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucperkins @nlewo