Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire-desktop: Add libdbusmenu dependency #96313

Merged
merged 1 commit into from Sep 14, 2020
Merged

wire-desktop: Add libdbusmenu dependency #96313

merged 1 commit into from Sep 14, 2020

Conversation

greydot
Copy link
Contributor

@greydot greydot commented Aug 25, 2020 •
edited

Allows using global menu in various desktop environments.

Motivation for this change

This is inspired by a similar PR for signal-desktop: #96078

Things done

Added libdbusmenu as a runtime dependency.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

toonn
toonn reviewed Aug 29, 2020
View reviewed changes
Copy link
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, however, I can't test on linux.

wire-desktop: Add libdbusmenu dependency
ad64c68 
Allows using global menu in various desktop environments.
@ofborg ofborg bot requested a review from toonn September 2, 2020 18:41
@Lassulus Lassulus merged commit 5f9ce9e into NixOS:master Sep 14, 2020
@greydot greydot deleted the wire/dbusmenu branch September 14, 2020 08:25
This was referenced Oct 11, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kiwi Kiwi Awaiting requested review from Kiwi

@arianvp arianvp Awaiting requested review from arianvp

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@toonn toonn Awaiting requested review from toonn

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@greydot @toonn @Lassulus