Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viewnior: 1.6 -> 1.7 & change upstream #96319

Merged
merged 1 commit into from Aug 27, 2020
Merged

viewnior: 1.6 -> 1.7 & change upstream #96319

merged 1 commit into from Aug 27, 2020

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Aug 25, 2020 •
edited

Things done

updated the version and changed the upstream to the official repo since the old one is dead
also changed how it builds because it was changed in 1.7 according to this
http://siyanpanayotov.com/project/viewnior/download

OLD REPO
NEW REPO

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from grwlf August 25, 2020 23:54
@Artturin Artturin changed the title viewnior: 1.6 -> 1.7 viewnior: 1.6 -> 1.7 & change upstream Aug 26, 2020
jonringer
jonringer approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/96319
1 package built:
viewnior

@jonringer
Copy link
Contributor

waiting for ofborg

@Artturin
Copy link
Member Author

added myself as a maintainer and cleaned the meta in the second force-push

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@danieldk danieldk merged commit ab24734 into NixOS:master Aug 27, 2020
@Artturin Artturin deleted the update-viewnior branch September 10, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@grwlf grwlf Awaiting requested review from grwlf

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Artturin @jonringer @danieldk