Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

papermc: cleanup #96277

Merged
merged 1 commit into from Aug 26, 2020
Merged

papermc: cleanup #96277

merged 1 commit into from Aug 26, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change
  • Use Nix store path for the shebang to make this work on systems
    without /bin/sh.
  • Replace phases by dont*.
  • Install jar file to $out/share/papermc rather than $out.
  • License gpl3 -> gpl3Only (couldn't find any evidence that this is
    gpl3Plus).

I don't use this, so I cannot really verify if this server works correctly.

cc @aaronjanse @TheUserCreated

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
papermc: cleanup
4bb0728 
- Use Nix store path for the shebang to make this work on systems
  without /bin/sh.
- Replace phases by dont*.
- Install jar file to $out/share/papermc rather than $out.
- License gpl3 -> gpl3Only (couldn't find any evidence that this is
  gpl3Plus).
@ofborg ofborg bot requested a review from aaronjanse August 25, 2020 13:18
aaronjanse
aaronjanse approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@aaronjanse aaronjanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a way to test this, but I don't see anything disagreeable in the code. Thanks @danieldk!

@TheUserCreated
Copy link
Contributor

Aha, I do have a way to test this! Works great, if theres something wrong then I can't find it.

@danieldk
Copy link
Contributor Author

Thanks @aaronjanse and @TheUserCreated for the review and testing this!

@danieldk danieldk merged commit ee40d9e into NixOS:master Aug 26, 2020
@danieldk danieldk deleted the papermc-cleanup branch August 26, 2020 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronjanse aaronjanse aaronjanse approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @TheUserCreated @aaronjanse