Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lvm2: link against libblkid #96278

Closed
wants to merge 1 commit into from
Closed

lvm2: link against libblkid #96278

wants to merge 1 commit into from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Aug 25, 2020

dmsetup requires it and is part of the extra-utils derivation used on all NixOS systems.

Motivation for this change

Fixes #96197.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
lvm2: link against libblkid
95a6a6f 
`dmsetup` requires it and is part of the `extra-utils` derivation used on all NixOS systems.
@FRidh
Copy link
Member Author

FRidh commented Aug 25, 2020

Testing now. This will be a mass-rebuild though.

@FRidh FRidh added the 1.severity: channel blocker Blocks a channel label Aug 25, 2020
@FRidh
Copy link
Member Author

FRidh commented Aug 25, 2020

Current staging-next looks quite good. I suggest we merge that into master, and then have a staging-next iteration with this commit along with the systemd change (#94354).

@ofborg ofborg bot requested review from ajs124 and 7c6f434c August 25, 2020 13:10
@FRidh
Copy link
Member Author

FRidh commented Aug 25, 2020

Seems like dmsetup in lvm2.bin was fine already, just not in extra-utils for me. Strange...

@FRidh FRidh closed this Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

@vcunat vcunat Awaiting requested review from vcunat

@jonringer jonringer Awaiting requested review from jonringer

@ajs124 ajs124 Awaiting requested review from ajs124

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
1.severity: channel blocker Blocks a channel 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NixOS Tests broken in master and staging
1 participant
@FRidh