Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_1password-gui: 0.8.2-1 -> 0.8.3-1 #96301

Merged
merged 2 commits into from Aug 27, 2020
Merged

_1password-gui: 0.8.2-1 -> 0.8.3-1 #96301

merged 2 commits into from Aug 27, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changes:
https://discussions.agilebits.com/discussion/115413/

Also add an update script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk merged commit 5f8d0e4 into NixOS:master Aug 27, 2020
@danieldk danieldk deleted the 1password-gui-0.8.3-1 branch August 27, 2020 12:24
@mlen
Copy link

mlen commented Aug 28, 2020

Is there any chance to get this backported to 20.03?

@danieldk
Copy link
Contributor Author

Is there any chance to get this backported to 20.03?

Not sure if it is worth it. 20.09 is branched soon and the release is probably in 1-2 months.

@mlen
Copy link

mlen commented Aug 28, 2020

True, but it would grant the ability to easily use it to all those who are using the stable branch for few more months

@danieldk
Copy link
Contributor Author

True, but it would grant the ability to easily use it to all those who are using the stable branch for few more months

I looked into it, but we do not have Electron 9 in 20.03.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @mlen