Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.termonad: mark unbroken #96265

Merged
merged 1 commit into from Aug 26, 2020
Merged

haskellPackages.termonad: mark unbroken #96265

merged 1 commit into from Aug 26, 2020

Conversation

cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Aug 25, 2020 •
edited

Motivation for this change

Unbreak Termonad in preparation for the branch-off for 20.09.

This was so easy thanks to the work by @maralorn to get the haskell-gi stuff working recently in #95434.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout cdepillabout merged commit 0a9d607 into NixOS:haskell-updates Aug 26, 2020
@cdepillabout cdepillabout deleted the unbreak-termonad branch August 26, 2020 03:43
@maralorn
Copy link
Member

I am a bit confused that this got fixed completely by my changes. But I‘ll take it. Glad it worked out!

@cdepillabout cdepillabout mentioned this pull request Aug 27, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdepillabout @maralorn