nixos: wpa_supplicant: warn on unused config #96263
Merged
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
After 71ea6a9 there are additional cases, where wpa_supplicant uses an auto-generated config.
Because it can't use multiple config files, and the config format doesn't permit includes, that will silently ignore a present
/etc/wpa_supplicant.conf
. There are valid reasons for keeping that file outside ofextraConfig
, because it may contain secrets.This is intended to avoid silently breaking people's config in 20.09
see #59959 (comment)
Things done
Implemented a run-time warning, that will detect a condition of
/etc/wpa_supplicant.conf
being present, but ignored in favor of a a generated config file.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)