Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsodium: feed c2hs dependency #96266

Merged
merged 3 commits into from Aug 28, 2020
Merged

Conversation

dminuoso
Copy link
Contributor

@dminuoso dminuoso commented Aug 25, 2020

Unbreaks haskellPackages.libsodium

Builds:

λ ~/git/nixpkgs/ unbreak-libsodium nix-build --no-out-link -A haskellPackages.libsodium --arg config '{ allowBroken = true; }'                  ~/git/nixpkgs
/nix/store/mp9wndxz5icwmvjf05sf5fi9if9scq5i-libsodium-1.0.18.1

The reason we need to do this is because the author neglected to include c2hs in build-tool-depends in the package uploaded to hackage. It's fixed in the git repo already, but this has not yet been published to hackage yet.

@dminuoso
Copy link
Contributor Author

Force pushed a fix and updated the PR description to reflect the need.

@cdepillabout
Copy link
Member

The reason we need to do this is because the author neglected to include c2hs in build-tool-depends in the package uploaded to hackage. It's fixed in the git repo already, but this has not yet been published to hackage yet.

Could you ask the author to upload a new release to Hackage? That should help Haskellers who don't use nixpkgs as well.

Co-authored-by: Dennis Gosnell <cdep.illabout@gmail.com>
@dminuoso
Copy link
Contributor Author

Done!

k0001/hs-libsodium#2 (comment)

@cdepillabout
Copy link
Member

@dminuoso Okay, let's wait a few days for a response from the upstream maintainer, and if he doesn't respond, we can go ahead and merge this PR into nixpkgs.

Co-authored-by: Dennis Gosnell <cdep.illabout@gmail.com>
@peti peti merged commit 23da09f into NixOS:haskell-updates Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants