Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 84.0.4147.135 -> 85.0.4183.83 #96308

Merged
merged 2 commits into from Aug 26, 2020
Merged

chromium: 84.0.4147.135 -> 85.0.4183.83 #96308

merged 2 commits into from Aug 26, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Aug 25, 2020 •
edited

https://chromereleases.googleblog.com/2020/08/stable-channel-update-for-desktop_25.html

This update includes 20 security fixes.

CVEs:
CVE-2020-6558 CVE-2020-6559 CVE-2020-6560 CVE-2020-6561 CVE-2020-6562
CVE-2020-6563 CVE-2020-6564 CVE-2020-6565 CVE-2020-6566 CVE-2020-6567
CVE-2020-6568 CVE-2020-6569 CVE-2020-6570 CVE-2020-6571

Testing status
platform attribute status tester
x86_64 chromium ✔️ @danielfullmer
x86_64 nixosTests.chromium N/A @danielfullmer
x86_64 google-chrome ✔️ @primeos
aarch64 chromium @thefloweringash

[Note: I forgot to update the gnChromium logic in pkgs/applications/networking/browsers/chromium/default.nix but that shouldn't matter. I'll try to improve that part for the next PR (though I keep forgetting about it... :o).]
NVM, I changed it before I forget about it again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos primeos added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 25, 2020
@primeos
chromium: Make the gnChromium overrides depend on the version
25aed42 
This is more robust than depending on the channel, though the version
should only matter if the configuration phase fails.
This also switches to the intended version for `chromium` which should
be higher since M85 is in the stable channel.

Thanks `@volth` for pointing this out.
@danielfullmer
Copy link
Contributor

chromium builds and tests fine on x86_64-linux. However, nixosTests.chromium doesn't build at this commit. It looks to be an unrelated problem with extra-utils in stage-1.nix

@primeos primeos merged commit b8fb1e1 into NixOS:master Aug 26, 2020
@primeos primeos mentioned this pull request Aug 27, 2020
Merged
10 tasks
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 1, 2020
@primeos @dtzWill
Merge pull request NixOS#96308 from primeos/chromium
e4db7b7 
chromium: 84.0.4147.135 -> 85.0.4183.83
(cherry picked from commit b8fb1e1)
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefloweringash thefloweringash Awaiting requested review from thefloweringash

@bendlas bendlas Awaiting requested review from bendlas

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@primeos @danielfullmer @TredwellGit