Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octoprint: 1.4.0 -> 1.4.2 #96294

Merged
merged 1 commit into from Aug 26, 2020
Merged

Octoprint: 1.4.0 -> 1.4.2 #96294

merged 1 commit into from Aug 26, 2020

Conversation

j0hax
Copy link
Member

@j0hax j0hax commented Aug 25, 2020

Motivation for this change

Simple Version bump; updated dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

gebner
gebner reviewed Aug 25, 2020
View reviewed changes
Copy link
Member

@gebner gebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you do print using the new version?
Do you know by any chance if the plugins need to be updated?

pkgs/applications/misc/octoprint/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/octoprint/default.nix Outdated Show resolved Hide resolved
@j0hax
Copy link
Member Author

j0hax commented Aug 25, 2020

Did you do print using the new version?

I have just successfully started one on an Ender 3.

Do you know by any chance if the plugins need to be updated?

I have not tested the few provided by octoprint/plugins.nix, however taking care of those would be my next task.

@j0hax j0hax requested a review from gebner August 25, 2020 19:21
@gebner
Copy link
Member

gebner commented Aug 25, 2020

I have just successfully started one on an Ender 3.

Great!

I have not tested the few provided by octoprint/plugins.nix, however taking care of those would be my next task.

Even better! The PR looks good from my side, I'll merge it when you report back from the plugins.

Finally: please squash the commits, and follow the commit message convention: octoprint: 1.4.0 -> 1.4.2

@j0hax
Copy link
Member Author

j0hax commented Aug 25, 2020

Alright, I think everything should be looking good now.

Plugins are still working as expected.

@gebner gebner merged commit 5df3339 into NixOS:master Aug 26, 2020
@j0hax j0hax deleted the octoprint-update branch August 26, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhittlesJr WhittlesJr Awaiting requested review from WhittlesJr

@abbradar abbradar Awaiting requested review from abbradar

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j0hax @gebner @Janik-Haag