noto-fonts-emoji: unstable-2019-10-22 → unstable-2020-08-20; twitter-color-emoji: 12.1.5 → 13.0.1 #96315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sternenseemann
force-pushed
the
noto-update
branch
from
f9818e6
to
17fa1be
Compare
sternenseemann
force-pushed
the
noto-update
branch
2 times, most recently
from
58f86c9
to
9ca80fd
Compare
sternenseemann
changed the title
|
Test failure on ofborg is very strange, I can reproduce it locally, but not 100% of the time. Seems to be related to timestamps, maybe nix is messing with it? |
jonringer
reviewed
Aug 26, 2020
jonringer
reviewed
Aug 26, 2020
sternenseemann
force-pushed
the
noto-update
branch
2 times, most recently
from
f9a1d49
to
dbcf37e
Compare
|
@jonringer Thanks for the good suggestions, let me know if I missed fixing any of them. |
|
cc @FRidh this is at 539 packages changed, around 1/4 of which are python packages. Should this go into staging? |
sternenseemann
force-pushed
the
noto-update
branch
2 times, most recently
from
81b1c74
to
729dc20
Compare
|
Not sure if we should also mark the package as broken on those platforms. At least we only need to build the fonts on one platform… |
jonringer
reviewed
Aug 27, 2020
pkgs/top-level/python-packages.nix
Outdated
| @@ -4932,6 +4950,8 @@ in { | |||
| else | |||
| callPackage ../development/python-modules/mutagen { }; | |||
|
|
|||
| mutatorMath = callPackage ../development/python-modules/mutatorMath { }; | |||
There was a problem hiding this comment.
Please normalize the attribute name. According to the python contributing guidelines, package names within nix should follow PEP 0503
There was a problem hiding this comment.
What about the pname attribute? Should it be like the attribute name or like in the pypi archive (so inherit pname is possible)?
There was a problem hiding this comment.
pname is fine to keep with the irregular format, so that it agrees with the fetchpypi usage
There was a problem hiding this comment.
the main thing is that referencing the package should be done through the normalized name (e.g. propagatedBuildInputs = [ mutatormath ];
There was a problem hiding this comment.
Then, all should be well now.
Now supports Unicode 13.0.
sternenseemann
force-pushed
the
noto-update
branch
from
729dc20
to
aa0f60b
Compare
|
@GrahamcOfBorg build python3Packages.fonttools python3Packages.afdko python3Packages.nototools |
jonringer
approved these changes
Aug 30, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update Noto Color Emoji and Twitter Color Emoji to support Unicode 13.0 for new emojis like 🏳️⚧️.
Following renderings are with the updated fonts from this PR:
TODO
noto-fonts-emojitwitter-emoji-colornixpkgs-review)?Also feedback especially on the new python packages would be appreciated. I'm not sure if there's a better way to handle the
extrasthan I'm doing right now.Also sorry for the huge PR, but all these changes are more or less related to each other, so opening thousands of PRs would be more of a hassle, I guess.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)