Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable trifecta tests on AArch64, as they tend to fail and prevent the build #96271

Closed
wants to merge 2 commits into from
Closed

Disable trifecta tests on AArch64, as they tend to fail and prevent the build #96271

wants to merge 2 commits into from

Conversation

golddranks
Copy link
Contributor

Motivation for this change

Trifecta 2.1 doctests fail and prevent the build. More details about the bug here: https://gitlab.haskell.org/ghc/ghc/-/issues/15275 and here: #96154

My own motivation for this is that this seems to block building ShellCheck and by that, also this PR: #91295

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    • Not all, but pandoc, which is one of the reverse deps, and even that took the whole day on my Raspberry Pi 4.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@golddranks
haskellPackages.trifecta: disable tests on AArch64
80b36b9 
The tests tend to fail and prevent the build of packages that depend on
this library, while the core reason for the test failure seems hard to
fix at the moment.
@cdepillabout
Copy link
Member

cdepillabout commented Aug 25, 2020 •
edited

@golddranks This looks good to me. Could you rebase this on the haskell-updates branch?

We generally like haskell-related stuff to go into the haskell-updates branch before merging into master.

@golddranks @cdepillabout
Update pkgs/development/haskell-modules/configuration-common.nix
90c768f 
Co-authored-by: Dennis Gosnell <cdep.illabout@gmail.com>
@golddranks
Copy link
Contributor Author

I'll send a new PR!

@golddranks golddranks closed this Aug 25, 2020
@golddranks golddranks mentioned this pull request Aug 25, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout left review comments

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@golddranks @cdepillabout @Janik-Haag