Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libappindicator: 12.10.0 -> 12.10.1.201020200706.1 #96296

Closed
wants to merge 1 commit into from
Closed

libappindicator: 12.10.0 -> 12.10.1.201020200706.1 #96296

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 25, 2020 •
edited

Motivation for this change

another attempt to fix discord

closes #96246
closes #96063

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

failures broken on master

https://github.com/NixOS/nixpkgs/pull/96296
3 packages failed to build:
quodlibet-full quodlibet-xine-full steam-run-native

80 packages built:
Sylk appimage-run audio-recorder autokey blueman deltachat-electron devdocs-desktop discord discord-canary discord-ptb dropbox dropbox-cli gammastep gitter gnome3.gnome-control-center gnome3.networkmanagerapplet gromit-mpx gspeech gxneur handbrake hubstaff indicator-application-gtk2 indicator-application-gtk3 irccloud joplin-desktop kazam keybase-gui ledger-live-desktop libappindicator libappindicator-gtk2 marktext mate.caja-dropbox mate.mate-control-center mate.mate-polkit meteo minetime minishift modem-manager-gui molotov mullvad-vpn mycrypto notable obsidian pantheon.elementary-greeter pantheon.switchboard-plug-network pantheon.switchboard-with-plugs pantheon.wingpanel-with-indicators pasystray perl528Packages.Gtk2AppIndicator perl530Packages.Gtk2AppIndicator plexamp protonvpn-gui python27Packages.syncthing-gtk radiotray-ng redshift redshift-plasma-applet redshift-wlr remmina runwayml safeeyes sc-controller shutter signal-desktop skype slack ssb-patchwork standardnotes station syncthing-tray systrayhelper timeular tusk udiskie uget uget-integrator ulauncher unityhub wootility xflux-gui zulip

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/discord-0-0-11-package-sometimes-randomly-crashes/8725/9

@ofborg ofborg bot requested a review from msteen August 25, 2020 18:17
@JJJollyjim
Copy link
Member

Is this different from #93453 ?

@jonringer
Copy link
Contributor Author

jonringer commented Aug 25, 2020 •
edited

Is this different from #93453 ?

not significantly, and I think I like theirs more

@jonringer jonringer closed this Aug 25, 2020
@jonringer jonringer deleted the bump-libappindicator branch August 25, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@msteen msteen Awaiting requested review from msteen

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

discord: Frequent segmentation faults in libappindicator
4 participants
@jonringer @nixos-discourse @JJJollyjim @worldofpeace