Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjfx14: correctly remove references to jdk11 #96298

Merged
1 commit merged into from Aug 26, 2020
Merged

openjfx14: correctly remove references to jdk11 #96298

1 commit merged into from Aug 26, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 25, 2020 •
edited by ghost

The new version string for jdk11 contains a '+' character, which needs
to be escaped for use in the sed command.
Fixes #95117.
Replaces #95123.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

openjfx14: correctly remove references to jdk11
60a0412 
The new version string for jdk11 contains a '+' character, which needs
to be escaped for use in the sed command.
Fixes #95117.
Replaces #95123.
@ghost ghost requested review from jerith666 and Ma27 August 25, 2020 18:06
@ofborg ofborg bot requested a review from abbradar August 25, 2020 18:26
jerith666
jerith666 approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@jerith666 jerith666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great sleuthing -- thanks!

@ghost ghost merged commit 5622b6b into NixOS:master Aug 26, 2020
Ericson2314 pushed a commit that referenced this pull request Jun 15, 2021
@Ericson2314
openjfx12: correctly remove references to jdk11 (#96298)
246b75a 
The new version string for jdk11 contains a '+' character, which needs
to be escaped for use in the sed command.
Fixes #95117.

(cherry picked from commit 5622b6b)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
1 participant
@jerith666