Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vokosscreenNG: Init at 3.0.5 #96297

Merged
merged 1 commit into from Sep 4, 2020
Merged

vokosscreenNG: Init at 3.0.5 #96297

merged 1 commit into from Sep 4, 2020

Conversation

SCOTT-HAMILTON
Copy link
Contributor

@SCOTT-HAMILTON SCOTT-HAMILTON commented Aug 25, 2020 •
edited by veprbl

Motivation for this change

Closes: #96286

Things done

Packaged version 3.0.5, not sure if it's gpl2Only, https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/video/vokoscreen/default.nix#L49 says gpl2Plus ?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SCOTT-HAMILTON SCOTT-HAMILTON mentioned this pull request Aug 25, 2020
Closed
@romildo
Copy link
Contributor

romildo commented Aug 26, 2020

Testing locally, I am getting some issues:

  • no áudio device has been detected
  • camera is unavailable
  • Qt-PluginsPath with unexpanded variables: /build/qtbase-everywhere-src-5.14.2/$(out)/$(qtPluginPrefix)
$ result/bin/vokoscreenNG 
[vokoscreenNG] Version: 3.0.5
[vokoscreenNG] Locale: en_US
[vokoscreenNG] Log from: 2020-08-26 08:51:50
[vokoscreenNG] Country: United States
[vokoscreenNG] Qt: 5.14.2
[vokoscreenNG] GStreamer 1.16.2
[vokoscreenNG] Operating system: NixOS 20.09 (Nightingale)
[vokoscreenNG] CPU Architecture: x86_64
[vokoscreenNG] vokoscreenNG running as: xcb client
[vokoscreenNG] vokoscreenNG running on: x11
[vokoscreenNG] Desktop: none+awesome
[vokoscreenNG] Icon-Theme: breeze
[vokoscreenNG] Styles: (Breeze, kvantum-dark, kvantum, qt5ct-style, Windows, Fusion)
[vokoscreenNG] Qt-PluginsPath:      /build/qtbase-everywhere-src-5.14.2/$(out)/$(qtPluginPrefix)
[vokoscreenNG] Qt-TranslationsPath: /nix/store/mk31d0mxsk4a0aamlfqwrwwg74nj6p5d-qtbase-5.14.2/translations
[vokoscreenNG] Qt-LibraryPath:      /nix/store/mk31d0mxsk4a0aamlfqwrwwg74nj6p5d-qtbase-5.14.2/lib
[vokoscreenNG] Settings: /home/romildo/.config/vokoscreenNG/vokoscreenNG.ini
[vokoscreenNG] Log: /home/romildo/.config/vokoscreenNG/log/2020_08_26_08_51_50.log
[vokoscreenNG] CompositingManager running: false

[vokoscreenNG] Symbols: + available, - not available
[vokoscreenNG] - matroskamux
[vokoscreenNG] - webmmux
[vokoscreenNG] - avimux
[vokoscreenNG] - mp4mux
[vokoscreenNG] - qtmux
[vokoscreenNG] - ximagesrc
[vokoscreenNG] - pulsesrc
[vokoscreenNG] - pipewiresrc
[vokoscreenNG] + queue
[vokoscreenNG] + capsfilter
[vokoscreenNG] - videoconvert
[vokoscreenNG] - videorate
[vokoscreenNG] - audioconvert
[vokoscreenNG] - audiorate
[vokoscreenNG] + filesink
[vokoscreenNG] - videoscale
[vokoscreenNG] - h264parse
[vokoscreenNG] - audiomixer
[vokoscreenNG] - adder

[vokoscreenNG] Name from screen:  eDP-1-1
[vokoscreenNG] Screen available desktop width : 1920
[vokoscreenNG] Screen available desktop height: 1080
[vokoscreenNG] DevicePixelRatio: 1  (Normal displays is 1, Retina display is 2)
[vokoscreenNG] Vertical refresh rate of the screen in Hz: 60.0204
[vokoscreenNG] Screen orientation Qt::LandscapeOrientation
[vokoscreenNG] Color depth of the screen:  24
[vokoscreenNG] Model from screen:  
[vokoscreenNG] Manufactur from screen:  
[vokoscreenNG] SerialNumber from screen:  
[vokoscreenNG] ItemText in Combobox: eDP-1-1 :  1920 x 1080
[vokoscreenNG] ItemData in Combobox: x=0 y=0 with=1920 height=1080

[vokoscreenNG] [Camera] Found: Integrated_Webcam_HD: Integrate /dev/video0
Warning: Error: cannot create camera service, the 'camerabin' plugin is missing for GStreamer 1.16.
Please install the 'bad' GStreamer plugin package. ((null):0, (null))
[vokoscreenNG] Camera service missing error
[vokoscreenNG] Desktop session is a X11 session

Probably it needs some gstream plugins as runtime dependencies (added to buildInputs).

@SCOTT-HAMILTON
Copy link
Contributor Author

Added gst-plugins, the camera is now working fine for me.

vbgl
vbgl reviewed Aug 31, 2020
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
@@ -27215,6 +27215,10 @@ in

vokoscreen = libsForQt5.callPackage ../applications/video/vokoscreen { };

vokoscreen-ng = libsForQt5.callPackage ../applications/video/vokoscreen-ng {
gstreamer = gst_all_1.gstreamer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gstreamer = gst_all_1.gstreamer;
inherit (gst_all_1) gstreamer gst-plugins-base gst-plugins-good gst-plugins-bad gst-plugins-ugly;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this has been lost…

@vbgl
Copy link
Contributor

vbgl commented Aug 31, 2020

@GrahamcOfBorg build vokoscreen-ng

vbgl
vbgl requested changes Sep 3, 2020
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
@@ -27215,6 +27215,10 @@ in

vokoscreen = libsForQt5.callPackage ../applications/video/vokoscreen { };

vokoscreen-ng = libsForQt5.callPackage ../applications/video/vokoscreen-ng {
gstreamer = gst_all_1.gstreamer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this has been lost…

@vbgl
Copy link
Contributor

vbgl commented Sep 3, 2020

@GrahamcOfBorg build vokoscreen-ng

doronbehar
doronbehar approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

https://github.com/NixOS/nixpkgs/pull/96297
1 package built:
vokoscreen-ng

Can't test functionality as I'm not using X11, but the gui seems to be OK.

@vbgl vbgl merged commit 4906881 into NixOS:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add VokoscreenNG to nixpkgs
4 participants
@SCOTT-HAMILTON @romildo @vbgl @doronbehar