Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update qcad to 3.25.0.0 #96310

Merged
merged 1 commit into from Sep 2, 2020
Merged

update qcad to 3.25.0.0 #96310

merged 1 commit into from Sep 2, 2020

Conversation

yvesf
Copy link
Member

@yvesf yvesf commented Aug 25, 2020

  • update upstream version to 3.25.0.0
  • fix the application desktop file to use the right binary name
  • make building more robust when qt version changes, automatically try
    to copy qtscriptgenerator directory
  • Built on platform(s)
    • NixOS
  • Tested execution of all binary files (usually in ./result/bin/)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/284

@risicle
Copy link
Contributor

risicle commented Aug 31, 2020

Bumps should have commit messages of the form packagename: oldver -> newver.

@yvesf yvesf force-pushed the qcad-3.25.0.0 branch 2 times, most recently from 2de6ee8 to 90c1b87 Compare September 1, 2020 07:24
* update upstream version to 3.25.0.0
* fix the application desktop file to use the right binary name
* make building more robust when qt version changes, automatically try
  to copy qtscriptgenerator directory
@risicle
Copy link
Contributor

risicle commented Sep 2, 2020

Works for me, linux x86_64 - I was trying to find a fix for it on macos too, but that's being a pain so I'll just merge this anyway and leave that for another time.

Note to anyone else wanting to pick this up: add qt5.qtmacextras, but the install/fixup process still needs to be sorted out.

@risicle risicle merged commit 0d820de into NixOS:master Sep 2, 2020
@yvesf yvesf deleted the qcad-3.25.0.0 branch October 27, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants