Fix state handling for transceiver.stop #25235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 25, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2375648
branch
from
997255f
to
85b40a8
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2375648
branch
2 times, most recently
from
cf5f696
to
05dab88
Compare
The JS-visible state wasn't always in sync after stop(). Also fix tests: Stop checking for "stopped" attribute that has been removed from spec. Change awaiting to account for negotiationNeeded being fired from setLocalDescription/setRemoteDescription(answer). Change expectations to account for transceivers disappearing from view when finally stopped. Still some remaining issues. Bug: chromium:980879 Change-Id: I5d4cb5482187ab40140ef99ac46f39a2d1628b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375648 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#806792}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2375648
branch
from
05dab88
to
a91b316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JS-visible state wasn't always in sync after stop().
Also fix tests:
Stop checking for "stopped" attribute that has been removed from spec.
Change awaiting to account for negotiationNeeded being fired from
setLocalDescription/setRemoteDescription(answer).
Change expectations to account for transceivers disappearing from view
when finally stopped.
Still some remaining issues.
Bug: chromium:980879
Change-Id: I5d4cb5482187ab40140ef99ac46f39a2d1628b27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375648
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806792}