New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cocoa to propagatedBuildInputs for tk #96267
Conversation
Otherwise packages using tk will not link correctly
I am currently building this PR and got two unrelated build failures so far and this one:
I am not sure if this is related to this PR or not. Do you have any idea? |
Hey, I don't know but I'm not sure how it could? How causes adding Cocoa to propagatedBuildInputs a missing/not found Does it compile without the patch?
which could definitely cause your issue. I think. Maybe. Likely. |
No clue either.
Currently compiling... (Note to myself: only compile over night. PyPy takes forever to compile.) After over 150 minutes:
|
I marked this as stale due to inactivity. → More info |
Otherwise packages using tk will not link correctly
Motivation for this change
I am trying to compile KiCad for macOS. Both tk and opencascade-occt are dependencies. opencascade-occt was not linking correctly for me because Cocoa was missing. So I added Cocoa to opencascade-occt buildInputs via an overlay. Upon closer inspection I found that opencascade-occt does not depend on Cocoa, but only tk. tk in turn depends on Cocoa on macOS and has Cocoa as buildInput set.
I believe the correct thing is to set Cocoa in propagatedBuildInputs of tk to allow packages depending on tk (such as opencascade-occt) to link correctly.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)