Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.autoapply: fix build #96355

Closed
wants to merge 1 commit into from
Closed

haskellPackages.autoapply: fix build #96355

wants to merge 1 commit into from

Conversation

expipiplus1
Copy link
Contributor

@expipiplus1 expipiplus1 commented Aug 26, 2020 •
edited

Motivation for this change

haskellPackages.autoapply: fix build

  • Don't run broken tests
  • Depend on correct version of th-desugar
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@expipiplus1
haskellPackages.autoapply: fix build
6b46d80 
- Don't run broken tests
- Depend on correct version of th-desugar
@expipiplus1 expipiplus1 changed the title <!-- To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates. Just leave a comment describing what you have tested in the relevant package/service. Reviewing helps to reduce the average time-to-merge for everyone. Thanks a lot if you do! List of open PRs: https://github.com/NixOS/nixpkgs/pulls Reviewing guidelines: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions --> haskellPackages.autoapply: fix build Aug 26, 2020
cdepillabout
cdepillabout reviewed Aug 26, 2020
View reviewed changes
pkgs/development/haskell-modules/configuration-common.nix
Comment on lines +1447 to +1448
# Missing a file required for tests in 0.4, fixed in 0.4.1
# Also use correct dependency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to just wait until nixpkgs is updated to autoapply-0.4.1?

Also, I think you'll need to mark autoapply as not broken.

Also, we usually like to target the haskell-updates branch for Haskell-related changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

It'll still need to use th-desugar-1.11. I'll close this PR and open a new one with just that change targeting the haskell-updates branch when nixpkgs is using 0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout left review comments

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@expipiplus1 @cdepillabout