Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fossil: install man page and bash shell completions, use system sqlite #96339

Merged
merged 2 commits into from Sep 1, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Some improvement for the fossil derivation:

  • Install the fossil(1) man page.
  • Install the bash shell completions.
  • Cleanup the derivation a bit.
  • Build against sqlite from buildInputs rather than the vendored sqlite.

Targets staging, because it requires the sqlite version that was merged into staging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/283

@danieldk danieldk merged commit 8ec5187 into NixOS:staging Sep 1, 2020
@danieldk danieldk deleted the fossil-improvements branch September 1, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants