Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 78.1.1 -> 78.2.1, 68.11.0 -> 68.12.0 #96360

Merged
merged 6 commits into from Aug 30, 2020
Merged

thunderbird, thunderbird-bin: 78.1.1 -> 78.2.1, 68.11.0 -> 68.12.0 #96360

merged 6 commits into from Aug 30, 2020

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Aug 26, 2020 •
edited

Motivation for this change
  • Various security fixes (68 only)
  • Updates and fixes.
  • OpenPGP enabled by default (78 only).

https://www.thunderbird.net/en-US/thunderbird/78.2.0/releasenotes/
https://www.thunderbird.net/en-US/thunderbird/78.2.1/releasenotes/
https://www.thunderbird.net/en-US/thunderbird/68.12.0/releasenotes/
https://www.mozilla.org/en-US/security/known-vulnerabilities/thunderbird/#thunderbird68.12

At this time, users of the Enigmail Add-on should not update to Thunderbird 78.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edolstra, lovesegfault and nbp August 26, 2020 11:28
@bbjubjub2494
Copy link
Member

commit description should read thunderbird: 78.1.1 -> 78.2.0 right?

@taku0
Copy link
Contributor Author

taku0 commented Aug 26, 2020

Yes. Fixed. Thank you.

@doronbehar
Copy link
Contributor

PR title as well ?

@vcunat vcunat changed the title thunderbird, thunderbird-bin: 68.10.0 -> 78.2.0 thunderbird, thunderbird-bin: 78.1.1 -> 78.2.0 Aug 27, 2020
@taku0 taku0 changed the title thunderbird, thunderbird-bin: 78.1.1 -> 78.2.0 thunderbird, thunderbird-bin: 78.2.1 -> 78.2.0, 68.11.0 -> 68.12.0 Aug 27, 2020
@taku0 taku0 marked this pull request as ready for review August 27, 2020 11:13
@vcunat vcunat changed the title thunderbird, thunderbird-bin: 78.2.1 -> 78.2.0, 68.11.0 -> 68.12.0 thunderbird, thunderbird-bin: 78.1.1 -> 78.2.0, 68.11.0 -> 68.12.0 Aug 27, 2020
@taku0 taku0 changed the title thunderbird, thunderbird-bin: 78.1.1 -> 78.2.0, 68.11.0 -> 68.12.0 thunderbird, thunderbird-bin: 78.1.1 -> 78.2.1, 68.11.0 -> 68.12.0 Aug 30, 2020
vcunat
vcunat approved these changes Aug 30, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK.

I used the compiled 78.2.0 for over three days continuously – and now each of the four versions for several minutes.

@vcunat vcunat merged commit f56bda0 into NixOS:master Aug 30, 2020
vcunat added a commit that referenced this pull request Aug 31, 2020
@vcunat
Merge #96360: thunderbird*: updates
27ac8de 
(cherry picked from commit f56bda0)
I briefly re-tested all of them atop 20.03.
@vcunat vcunat mentioned this pull request Aug 31, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taku0 @bbjubjub2494 @doronbehar @vcunat