Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-build-uncached: remove the nix wrap #96357

Merged
merged 1 commit into from Aug 26, 2020
Merged

nix-build-uncached: remove the nix wrap #96357

merged 1 commit into from Aug 26, 2020

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Aug 26, 2020

Nix is one of those few things where it's actually better to use the
version that is on the host. This avoids having to deal with Nix
compatibility issues, and download a second version of Nix on hosts like
GitHub Actions.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm
nix-build-uncached: remove the nix wrap
0d83240 
Nix is one of those few things where it's actually better to use the
version that is on the host. This avoids having to deal with Nix
compatibility issues, and download a second version of Nix on hosts like
GitHub Actions.
@zimbatm zimbatm mentioned this pull request Aug 26, 2020
Merged
@zimbatm zimbatm requested a review from Mic92 August 26, 2020 10:20
@ofborg ofborg bot requested a review from kalbasit August 26, 2020 10:48
@zimbatm zimbatm merged commit 2f5277d into NixOS:master Aug 26, 2020
@zimbatm zimbatm deleted the nix-build-uncached-remix branch August 26, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zimbatm @Mic92