Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libseccomp: disable RISC-V 32bit architecture #96337

Merged
merged 1 commit into from Aug 26, 2020
Merged

libseccomp: disable RISC-V 32bit architecture #96337

merged 1 commit into from Aug 26, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 26, 2020 •
edited

Motivation for this change

The libseccomp changelogs only indicate support for 64bit, not 32bit.

cc @JohnAZoidberg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@saschagrunert
libseccomp: disable RISC-V 32bit architecture
a3af2bb 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert mentioned this pull request Aug 26, 2020
Merged
10 tasks
JohnAZoidberg
JohnAZoidberg approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Unfortunately they have only added riscv64 support:

@JohnAZoidberg JohnAZoidberg merged commit 57ea612 into NixOS:staging Aug 26, 2020
@saschagrunert saschagrunert deleted the staging-libseecomp-arch branch August 26, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschagrunert @JohnAZoidberg