Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

klavaro: add link to changelog #96375

Merged
merged 1 commit into from Aug 27, 2020
Merged

klavaro: add link to changelog #96375

merged 1 commit into from Aug 27, 2020

Conversation

davidak
Copy link
Member

@davidak davidak commented Aug 26, 2020 •
edited

Motivation for this change

this makes review easier

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@davidak
klavaro: add link to changelog
a130188 
this makes review easier
@davidak
Copy link
Member Author

davidak commented Aug 26, 2020

klavaro is not built with

[d@n:~/code/nixpkgs]$ nix-shell -p nixpkgs-review --run "nixpkgs-review pr 96375"

probably because i have it already and the change does not influence the end package?
at least i don't get an error

@bhipple bhipple merged commit 234dba2 into NixOS:master Aug 27, 2020
@davidak davidak deleted the patch-2 branch August 27, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidak @bhipple