Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging-next stabilization #96342

Merged
merged 8 commits into from Aug 26, 2020
Merged

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 26, 2020

Motivation for this change

just marking a few broken packages as disabled

for the other commits, please look at commit message for details as to why they were done

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Jonathan Ringer added 6 commits August 26, 2020 00:21
This reverts commit ff21fc4.

sphinx_rtd_theme 0.5.0 requires a significant amount of bootstrapping
with node packages, which are not trivial
parsing of POPPLER_MINOR_VERSION is broken, as it doesn't truncate
leading zeroes. Leading gcc to believe it's trying to evaluate an
octal value (e.g. 08 > 72 ). However, 8 isn't a valid octal value.

Patches from master do not apply cleanly do a series of changes
done to configure.ac. So instead, a commit from master was chosen.
@jonringer
Copy link
Contributor Author

just remember, that these are all broken on staging-next

@ofborg ofborg bot requested a review from kamilchm August 26, 2020 08:11
@FRidh FRidh merged commit 5baf8f9 into NixOS:staging-next Aug 26, 2020
@jonringer jonringer deleted the fix-staging-next branch August 26, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants