Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atlassian-jira: 8.10.0 -> 8.11.1 #96362

Closed
wants to merge 1 commit into from
Closed

atlassian-jira: 8.10.0 -> 8.11.1 #96362

wants to merge 1 commit into from

Conversation

basilgood
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [X ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin, ciil and fpletz August 26, 2020 11:54
@ajs124
Copy link
Member

ajs124 commented Sep 2, 2020

Isn't 8.12 already out?

ciil
ciil suggested changes Sep 2, 2020
View reviewed changes
Copy link
Member

@ciil ciil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajs124 I think it just came out, I was too slow with reviewing again, @basilgood could you update your PR?

@basilgood basilgood closed this Sep 6, 2020
@basilgood basilgood deleted the atlassian-jira-8.11.1 branch September 6, 2020 06:23
@basilgood
Copy link
Contributor Author

@ajs124 I think it just came out, I was too slow with reviewing again, @basilgood could you update your PR?

#97279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciil ciil ciil requested changes

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@basilgood @ajs124 @ciil