Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncgopher: Init at 0.1.5 #96372

Merged
merged 2 commits into from Aug 27, 2020
Merged

ncgopher: Init at 0.1.5 #96372

merged 2 commits into from Aug 27, 2020

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

#87784

Things done

Packaged ncgopher at release 0.1.5. (Spoiler: takes some time to build)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SCOTT-HAMILTON SCOTT-HAMILTON mentioned this pull request Aug 26, 2020
Closed
@OmnipotentEntity
Copy link
Contributor

The cargo sha256 is not matching for me.

[14.5 MiB DL]
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/96372/head:refs/nixpkgs-review/1
remote: Enumerating objects: 13, done.
remote: Counting objects: 100% (13/13), done.
remote: Compressing objects: 100% (7/7), done.
remote: Total 16 (delta 6), reused 6 (delta 6), pack-reused 3
Unpacking objects: 100% (16/16), 189.59 KiB | 1.97 MiB/s, done.
From https://github.com/NixOS/nixpkgs
   232dbcc5a13..93b5c08d48f  master     -> refs/nixpkgs-review/0
$ git worktree add /root/.cache/nixpkgs-review/pr-96372/nixpkgs 93b5c08d48f4ef9d6b700301873e6673d20a1170
Preparing worktree (detached HEAD 93b5c08d48f)
Updating files: 100% (22574/22574), done.
HEAD is now at 93b5c08d48f Merge pull request #86449 from sorki/dt-schema
$ git merge --no-commit 7a055c11e4fbace9797b72c81779f74208ec10cc
Auto-merging pkgs/top-level/all-packages.nix
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /root/.cache/nixpkgs-review/pr-96372/build.nix
hash mismatch in fixed-output derivation '/nix/store/xgplx03hv5v1d15dmqi2p11wrqdzcl5a-ncgopher-0.1.5-vendor.tar.gz':
  wanted: sha256:11gn31jfdbjcp3mcg1c3iyxk3s0dkmiwa64q01zkvd9yw6n9yjv5
  got:    sha256:12r4vgrg2bkr3p61yxcsg02kppg84vn956l0v1vb08i94rxzc8zk
cannot build derivation '/nix/store/8r92zhm8qiqsph172c4r33bj2l35k6zi-ncgopher-0.1.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/504z6lj2zjsp959j5xnhy5j8pbkw2rz7-env.drv': 1 dependencies couldn't be built
[0 built (1 failed)]
error: build of '/nix/store/504z6lj2zjsp959j5xnhy5j8pbkw2rz7-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/96372
1 package failed to build:
ncgopher

[0.0 MiB DL]
error: build log of '/nix/store/8r92zhm8qiqsph172c4r33bj2l35k6zi-ncgopher-0.1.5.drv' is not available
$ nix-shell /root/.cache/nixpkgs-review/pr-96372/shell.nix

@SCOTT-HAMILTON
Copy link
Contributor Author

All checked have passed, how is this possible?

@SCOTT-HAMILTON
Copy link
Contributor Author

*checks

@jonringer
Copy link
Contributor

all checks did not pass https://github.com/NixOS/nixpkgs/pull/96372/checks?check_run_id=1031772020

@SCOTT-HAMILTON
Copy link
Contributor Author

changed vendorSha256 to ofborg's one, should if it.

@SCOTT-HAMILTON @jonringer
Update pkgs/applications/networking/ncgopher/default.nix
df3ddee 
Co-authored-by: Jon <jonringer@users.noreply.github.com>
@OmnipotentEntity
Copy link
Contributor

OmnipotentEntity commented Aug 27, 2020 •
edited

Builds fine. Executable runs. Attempting to browse gopherpedia I get an error when attempting to follow a link, but entering the url directly works fine. I do not know if this is a bug with the program or a bug with the build. But considering this is 0.1.5 it's probably a program bug. So lgtm

After relaunching the program I can no longer reproduce this error. LGTM

jonringer
jonringer approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/96372
1 package built:
ncgopher

@jonringer jonringer merged commit 80c458b into NixOS:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SCOTT-HAMILTON @OmnipotentEntity @jonringer