Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lbry: init at 0.48.2 #96368

Closed
wants to merge 2 commits into from
Closed

lbry: init at 0.48.2 #96368

wants to merge 2 commits into from

Conversation

IslandUsurper
Copy link

I would have preferred to make it from source, but couldn't get it to work. So this is derived from the .deb.

Motivation for this change

Add application to watch videos hosted on LBRY. I used this app before I switched to NixOS, so I'm motivated to keep maintaining it, as new versions come out fairly regularly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@IslandUsurper
Copy link
Author

Fixes #78766. Obsoletes #85769.

@IslandUsurper IslandUsurper changed the title lbry: init at 0.47.1 lbry: init at 0.47.2 Sep 16, 2020
@IslandUsurper IslandUsurper force-pushed the lbry-desktop branch 2 times, most recently from e98a209 to 806dcf7 Compare September 16, 2020 18:01
@IslandUsurper IslandUsurper force-pushed the lbry-desktop branch 2 times, most recently from 045e577 to 127bf7f Compare September 23, 2020 16:22
@IslandUsurper IslandUsurper changed the title lbry: init at 0.47.2 lbry: init at 0.48.0 Sep 23, 2020
@bqv
Copy link
Contributor

bqv commented Oct 4, 2020

Hi @IslandUsurper, if you update this, I'd like to try and get some attention on it

@IslandUsurper
Copy link
Author

Hi, @bqv. What kind of update are you looking for?

@bqv
Copy link
Contributor

bqv commented Oct 5, 2020

Nevermind, I misread the title and thought it was an older version!

bqv
bqv approved these changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@bqv bqv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been using this, it works well, and can be updated to 0.48.1 when that is released by adding pkgs.{libdrm,mesa} to rpath

@IslandUsurper
Copy link
Author

Ooh, thanks for the tip. I haven't been looking at the pre-releases.

@IslandUsurper IslandUsurper changed the title lbry: init at 0.48.0 lbry: init at 0.48.1 Oct 15, 2020
@IslandUsurper IslandUsurper changed the title lbry: init at 0.48.1 lbry: init at 0.48.2 Oct 17, 2020
@bqv
Copy link
Contributor

bqv commented Oct 17, 2020

/marvin opt-in
/status needs_merger

@mlvzk
Copy link
Member

mlvzk commented Nov 7, 2020

I was just looking for this, can this get merged?

SuperSandro2000
SuperSandro2000 reviewed Nov 24, 2020
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/applications/video/lbry/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/lbry/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/lbry/default.nix Show resolved Hide resolved
pkgs/applications/video/lbry/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/lbry/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 96368 run on x86_64-linux 1

1 package built:
  • lbry

@SuperSandro2000 SuperSandro2000 mentioned this pull request Nov 27, 2020
Closed
10 tasks
@SuperSandro2000
Copy link
Member 

  patching sources
  configuring
  no configure script, doing nothing
  glibPreInstallPhase
  installing
  patchelf: cannot find section '.interp'. The input file is most likely statically linked
cannot build derivation '/nix/store/3gqpfgikyaq41rawn423lqijl7k924ns-env.drv': 1 dependencies couldn't be built

@IslandUsurper IslandUsurper force-pushed the lbry-desktop branch 2 times, most recently from 70419ab to 636b828 Compare December 2, 2020 19:11
@IslandUsurper
Copy link
Author

I don't think I can find a better way to run patchelf than with the || true bit. If anyone knows a better way, I'm happy to include it, but other packages, like slack, need to be updated to do that as well.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 96368 run on x86_64-linux 1

1 package built:
  • lbry

@mhuesch
Copy link

mhuesch commented Dec 18, 2020

thanks for doing this work @IslandUsurper, I would be very interested to see LBRY merged in. if there’s something I can do to help the process along let me know 🙂

@IslandUsurper
Copy link
Author

You're welcome, @mhuesch. I think for this PR we just need to get clarification on what @SuperSandro2000 wanted changed, and then a merge.

That said, LBRY has come out with newer versions since 0.48.2, but I can't get them to work. Anyone willing to take a stab at it is welcome, because I'd like to be able to keep this package up to date.

@bqv
Copy link
Contributor

bqv commented Dec 18, 2020

To clarify, what issue are you having

@IslandUsurper
Copy link
Author 

❯ result/bin/lbry 
Starting SDK
Sandbox listening on port 5278.
Daemon: [6517] Cannot open self /nix/store/1afmqqgn95g1yp7kvwcvygxdkasla14y-lbry-0.49.1/LBRY/resources/static/daemon/lbrynet or archive /nix/store/1afmqqgn95g1yp7kvwcvygxdkasla14y-lbry-0.49.1/LBRY/resources/static/daemon/lbrynet.pkg

But that file exists, and you actually get the same error if you run that file on its own:

❯ /nix/store/1afmqqgn95g1yp7kvwcvygxdkasla14y-lbry-0.49.1/LBRY/resources/static/daemon/lbrynet 
[6689] Cannot open self /nix/store/1afmqqgn95g1yp7kvwcvygxdkasla14y-lbry-0.49.1/LBRY/resources/static/daemon/lbrynet or archive /nix/store/1afmqqgn95g1yp7kvwcvygxdkasla14y-lbry-0.49.1/LBRY/resources/static/daemon/lbrynet.pkg

My result links to that store path, lbrynet is executable by anyone, and all of its parent folders are readable and executable. I don't know if it's trying to daemonize and failing or what, but it started happening with v0.49.0.

@IslandUsurper
Copy link
Author

Running lbry causes the main app window to open, but an error dialog appears with

The daemon may have encountered an unexpected error, or another daeemon instance is already running.

For more information please visit:
https://lbry.com/faq/startup-troubleshooting

However there isn't another instance running, I don't think.

@bqv
Copy link
Contributor

bqv commented Dec 18, 2020 •
edited

I'm not sure what your derivation is, but i feel like that failure indicates bad linkage, perhaps experiment with patchelf and ldd?

Immediate edit: fwiw I might be talking out my arse here, I've not looked into this at all

@IslandUsurper
Copy link
Author

I'm not sure I have the motivation to work on this any more. It looks like there's still interest from some people, so hopefully someone else can take up the torch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bqv bqv bqv approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@IslandUsurper @bqv @mlvzk @SuperSandro2000 @mhuesch @Janik-Haag