Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcitx: Add test (Unicode input, table input, m17n) #96371

Merged
merged 2 commits into from Nov 19, 2020
Merged

fcitx: Add test (Unicode input, table input, m17n) #96371

merged 2 commits into from Nov 19, 2020

Conversation

asdf8dfafjk
Copy link
Contributor

@asdf8dfafjk asdf8dfafjk commented Aug 26, 2020 •
edited

Motivation for this change

Added test for fcitx

Things done

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/273

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/need-help-writing-a-test/8522/8

jtojnar
jtojnar reviewed Aug 26, 2020
View reviewed changes
nixos/tests/fcitx/config Outdated Show resolved Hide resolved
@asdf8dfafjk
Copy link
Contributor Author

Hi, Thank you!

I made another commit, you can look at the diff of .nix file and look at the config, profile files in their own right (not diffs). I will squash the two commits before you merge.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-many-people-are-paid-to-work-on-nix-nixpkgs/8307/86

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-setup-an-input-method-for-cjk-users/9533/4

@roberth
Copy link
Member

roberth commented Nov 19, 2020

This is great. Thank you so much @asdf8dfafjk !

@roberth roberth merged commit c790ed8 into NixOS:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asdf8dfafjk @nixos-discourse @roberth @jtojnar