Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jpexs: init at 11.3.0 #99294

Merged
merged 1 commit into from Oct 2, 2020
Merged

jpexs: init at 11.3.0 #99294

merged 1 commit into from Oct 2, 2020

Conversation

samuelgrf
Copy link
Member

@samuelgrf samuelgrf commented Oct 1, 2020 •
edited

Motivation for this change

I use this for removing copy protection from Flash games/animations, so they can be archived and played offline.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

doronbehar
doronbehar requested changes Oct 2, 2020
View reviewed changes
pkgs/development/tools/jpexs/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/jpexs/default.nix Show resolved Hide resolved
@doronbehar
Copy link
Contributor

Result of nixpkgs-review pr 99294 1

1 package built:
  • jpexs

doronbehar
doronbehar approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nixpkgs-review build and --help test.

@doronbehar doronbehar merged commit 6488d44 into NixOS:master Oct 2, 2020
@samuelgrf samuelgrf deleted the initpkg/jpexs branch March 5, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuelgrf @doronbehar