teams: remove rect-overlay -- causes desktop sharing to break without a composer #99279
Conversation
|
If we include such a hack a comment in the package would go a long way. Also please recheck https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md, specifically with regard to commit messages. |
|
@mweinelt thanks for the review, how does that look? |
|
The comment reads nicely, you can move it just above the Please note, I cannot decide if this change goes in, that should be the maintainers decision. |
|
Yes please! This has been crippling for me the past week or two 😱 |
|
@jonringer has this been biting you too? |
I wish this issue was biting me. But on sway teams just collapses in on itself when I want to start sharing my screen. I wonder if this is related. |
|
I've noticed it too, and I was just using chromium + web. |
|
This looks like the relevant upstream bug report, right? So for a proper fix we are waiting for upstream. For the users that are running a compositor, who currently do not have this issue, this change would cause the red border not to appear when screen sharing is active? Perhaps this could be something that could be conditionally enabled via an argument to the derivation so that the feature could be kept if it is working properly. An altenative solution, I suppose, could be to wrap |
|
The same workaround was committed in 1489c07. |
The rect-overlay doesn’t work on non-composited window managers such as i3 but it’s not a problem for others. Make the choice available via an argument to the derivation. The setting defaults to `false` so that it works for a broader set of users. See also: NixOS#99279.
Motivation for this change
Screen sharing on Teams is currently broken unless the user is using a composer (not that common across NixOS users).
This
rect-overlaydraws a rectangular red border around the screen, indicating that a recording is in process.Removing the file makes screen sharing work.
I am not sure if we want to include this small hack in nixpkgs, but even if this PR is closed it might still be useful as a reference for Teams users.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)