Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgxg: Init at 0.1.2 #99302

Closed
wants to merge 3 commits into from
Closed

rgxg: Init at 0.1.2 #99302

wants to merge 3 commits into from

Conversation

hloeffler
Copy link
Contributor

@hloeffler hloeffler commented Oct 1, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hloeffler hloeffler changed the title rgxg init rgxg: Init at 0.1.2 Oct 1, 2020
doronbehar
doronbehar requested changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, your PR should have eventually two commits:

maintainers: add <me>
<package-name>: init at <version>

pkgs/tools/text/rgxg/default.nix Show resolved Hide resolved
pkgs/tools/text/rgxg/default.nix
Comment on lines +14 to +15
doInstallCheck = true;
installCheckTarget = "check";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong with regular doCheck and checkTarget?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing,
i don't understand everything yet, this was copied from an other package, and i was just happy that it worked

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you are new :) Welcome aboard. I don't know where you borrowed that from, but it's considered more common to use doCheck = true. check is the default check (make) target for doCheck, so you should spare yourself 1 line of from the expression. For more info, refer to https://nixos.org/nixpkgs/manual/#chap-stdenv .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to edit my commits here, so i created a new pr with 2 commits:
#99422

Thanks for the weclome

pkgs/tools/text/rgxg/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/rgxg/default.nix Outdated Show resolved Hide resolved
hloeffler and others added 2 commits October 2, 2020 22:01
@hloeffler @doronbehar
Update pkgs/tools/text/rgxg/default.nix
80f5cb2 
Co-authored-by: Doron Behar <doron.behar@gmail.com>
@hloeffler @doronbehar
Update pkgs/tools/text/rgxg/default.nix
d867f7a 
Co-authored-by: Doron Behar <doron.behar@gmail.com>
@hloeffler
Copy link
Contributor Author

Thank you for your time and feedback,
i will find out how to do it

@hloeffler
Copy link
Contributor Author

i created a new one: #99422

@hloeffler hloeffler closed this Oct 2, 2020
@hloeffler hloeffler deleted the rgxg-init branch October 8, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hloeffler @doronbehar @Janik-Haag