Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnadd: init at 1.0.0 #99248

Merged
merged 2 commits into from Nov 28, 2020
Merged

dnadd: init at 1.0.0 #99248

merged 2 commits into from Nov 28, 2020

Conversation

JoeLancaster
Copy link
Contributor

Motivation for this change

I wanted a tool to add NixOS packages with a single command (nix-env -i style) that still works declaratively and leaves my system congruent to my configuration.nix

Other users may also find it helpful

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JoeLancaster JoeLancaster force-pushed the joelancaster-nixadd-v1_0_0 branch 2 times, most recently from 7c8f7ef to c90b09d Compare October 1, 2020 10:14
@fzakaria
Copy link
Contributor

fzakaria commented Oct 1, 2020

Result of nixpkgs-review pr 99248 1

1 package built:
- nixadd

jonringer
jonringer reviewed Oct 1, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems that this uses nixos-rebuild as the entry point, which is only available on nixos. Should it be called nixosadd?

pkgs/tools/nix/nixadd/default.nix Outdated Show resolved Hide resolved
@fzakaria
Copy link
Contributor

fzakaria commented Oct 1, 2020 •
edited

As a review of a package & Nix expression it looks 👍 ; as a tool I have somewhat the same feedback as @jonringer

I just worry about namespacing now in nixpkgs too with the number of pkgs present & how easy it's become for everyone to submit their own tool.

@JoeLancaster JoeLancaster force-pushed the joelancaster-nixadd-v1_0_0 branch 3 times, most recently from 14e3b6c to e1de9b5 Compare October 2, 2020 19:28
@JoeLancaster JoeLancaster changed the title nixadd: init at 1.0.0 dnadd: init at 1.0.0 Oct 2, 2020
@JoeLancaster
Copy link
Contributor Author

@fzakaria @jonringer You both make good points and I agree that community projects' superfluous use of nix probably steps on the toes of the official tooling. I've renamed the project to dnadd.

jtojnar
jtojnar reviewed Oct 5, 2020
View reviewed changes
pkgs/tools/nix/dnadd/default.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/dnadd/default.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/dnadd/default.nix Outdated Show resolved Hide resolved
pkgs/tools/nix/dnadd/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99248 run on x86_64-linux 1

1 package built:
  • dnadd

@SuperSandro2000 SuperSandro2000 merged commit 9445441 into NixOS:master Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@jonringer jonringer jonringer left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JoeLancaster @fzakaria @SuperSandro2000 @jtojnar @jonringer