New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zncModules.clientbuffer: 2015-08-27 -> 2020-04-24 #99289
Conversation
CC @hrdinka (maintainer) |
0811da3
to
cf69190
Compare
@ofborg eval |
@szlend I just noticed that you are a first time contributor. Thanks for the update, your work and welcome on board! In case you plan to stick around longer and make more contributions in the future, you can think about adding yourself as a maintainer for this derivation. More about this here https://nixos.wiki/wiki/Nixpkgs#Becoming_a_Nixpkgs_maintainer Have a nice day, Christoph |
@hrdinka Thank you, I would gladly help maintain this derivation. I'll go ahead and add myself to the maintainers. I already tried doing so but I reverted it after a failed build. Reading through it now, it looks as I forgot to add myself to the |
cf69190
to
6084bd6
Compare
Yes, that was definitely the problem. Just add another commit to this pull request and make sure to name both correct regarding https://nixos.org/manual/nixpkgs/stable/#chap-submitting-changes The actual commit containing the update should be name |
6084bd6
to
41f6274
Compare
Great 👍 welcome on board! Now lets wait for OfBorg to finish. |
Thanks for the help @hrdinka. Should be good to go now :) |
Thanks for the changes and congrats to your first NixOS contribution 👍 |
Motivation for this change
The original clientbuffer ZNC module has been abandoned since 2015. It has been picked up and maintained as a fork by another maintainer (https://github.com/CyberShadow/znc-clientbuffer).
This is now the recommended repo by the ZNC wiki page (https://wiki.znc.in/Clientbuffer)
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)